Skip to content

[Documentation:Developer] Improve php unit test instructions #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2025

Conversation

martig7
Copy link
Contributor

@martig7 martig7 commented Jun 26, 2025

It turns out that no one knows how to run the full php unit test suite and have it pass, so I investigated the php unit test instructions and Improved them. @lavalleeale has some changes at https://github.com/Submitty/Submitty/pull/11802 to allow for the full suite to pass so these docs should match that.

@bmcutler bmcutler requested a review from lavalleeale June 30, 2025 20:02
Copy link
Contributor

@lavalleeale lavalleeale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one specific suggestion, but I think we should discuss as a team before this gets merged since a lot of the install_php.md file seems outdated around what you added.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jul 16, 2025
Copy link
Contributor

@lavalleeale lavalleeale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs now match correct commands, lgtm

@github-project-automation github-project-automation bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Jul 17, 2025
@bmcutler bmcutler merged commit 04e6ffc into main Jul 18, 2025
3 checks passed
@bmcutler bmcutler deleted the phpunit-docs-improvements branch July 18, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants